Fix remembering scrolling position #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi many thanks for this :) I did some digging and it turns out that the call of It turns out it would be sufficient to just call |
|
I'm just glad I could help and that you found a sane workaround. This PR was never intended to be a merge request anyway, so no worries about pushing the proper fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #232
Since 0058352 the tabs albums and artists do not remember the user's position anymore. The culprit seems to be a call not happening early on in
onCreateView()but rather with initialization inonViewCreated().Reverting this does not seem like an ideal solution. Suggestions are welcome in case anybody knows how to handle this properly.